Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit metric when there are no functions #388

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Dec 3, 2020

No description provided.

@Luni-4 Luni-4 requested a review from marco-c December 3, 2020 10:25
@Luni-4 Luni-4 force-pushed the fix-exit branch 2 times, most recently from b57582a to 8f2f432 Compare December 4, 2020 23:46
@marco-c
Copy link
Collaborator

marco-c commented Dec 24, 2020

Same as #387 here

@codecov-io
Copy link

Codecov Report

Merging #388 (1601cc5) into master (2fff14d) will increase coverage by 0.33%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   23.29%   23.62%   +0.33%     
==========================================
  Files          45       45              
  Lines        5491     5870     +379     
  Branches      805      826      +21     
==========================================
+ Hits         1279     1387     +108     
- Misses       3689     3947     +258     
- Partials      523      536      +13     
Impacted Files Coverage Δ
src/macros.rs 28.12% <ø> (-23.23%) ⬇️
src/metrics/exit.rs 63.21% <75.00%> (+7.33%) ⬆️
src/c_macro.rs 66.15% <0.00%> (-14.98%) ⬇️
src/metrics/mi.rs 46.00% <0.00%> (-14.61%) ⬇️
src/metrics/halstead.rs 34.19% <0.00%> (-10.97%) ⬇️
src/metrics/loc.rs 47.40% <0.00%> (-6.57%) ⬇️
src/spaces.rs 56.28% <0.00%> (-5.56%) ⬇️
src/metrics/nom.rs 49.41% <0.00%> (-1.91%) ⬇️
src/languages/language_cpp.rs 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fff14d...1601cc5. Read the comment docs.

@marco-c marco-c merged commit 77ca5ea into mozilla:master Jan 25, 2021
@Luni-4 Luni-4 deleted the fix-exit branch January 25, 2021 10:04
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants