Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Linux release binaries with the musl library #413

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jan 8, 2021

This PR fixes #413.

Using musl avoids that binaries don't run because of some not updated dependencies.

@Luni-4 Luni-4 marked this pull request as draft January 11, 2021 13:24
@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #413 (8b85b36) into master (adf3cbc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   22.18%   22.18%           
=======================================
  Files          45       45           
  Lines        5797     5797           
  Branches      822      822           
=======================================
  Hits         1286     1286           
  Misses       3988     3988           
  Partials      523      523           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf3cbc...8b85b36. Read the comment docs.

@Luni-4 Luni-4 changed the title [DO NOT MERGE]Test rust-code-analysis build on Alpine Build Linux binaries with Musl Jan 11, 2021
@Luni-4 Luni-4 marked this pull request as ready for review January 11, 2021 13:43
@Luni-4 Luni-4 force-pushed the test-alpine branch 3 times, most recently from 2a474b1 to 5a30dfc Compare January 11, 2021 15:48
@Luni-4 Luni-4 requested a review from marco-c January 11, 2021 15:49
@Luni-4 Luni-4 changed the title Build Linux binaries with Musl Build Linux release binaries with the musl library Jan 11, 2021
.taskcluster.yml Outdated Show resolved Hide resolved
@Luni-4 Luni-4 force-pushed the test-alpine branch 3 times, most recently from 3cf5e09 to 1882667 Compare January 14, 2021 16:23
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jan 14, 2021

To build correctly the tree-sitter submodules with the rust:buster image, we need to re-set up the CC and CXX environment variables to the system compilers since musl sets those variables to its own compilers.

env CC=\"gcc\" CXX=\"g++\" cargo build --workspace --release --target **x86_64-unknown-linux-musl

As stated by this discussion also: tree-sitter/tree-sitter#794 (reply in thread)

@Luni-4 Luni-4 force-pushed the test-alpine branch 2 times, most recently from f05288a to d2a86ff Compare January 14, 2021 17:31
@marco-c marco-c merged commit 2a18ddf into mozilla:master Jan 14, 2021
@Luni-4 Luni-4 deleted the test-alpine branch January 14, 2021 18:20
@marco-c marco-c linked an issue Jan 14, 2021 that may be closed by this pull request
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
marco-c added a commit that referenced this pull request Apr 8, 2021
This reverts commit 2a18ddf.

This likely caused released binaries to be broken (see #606).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build rust-code-analysis-cli with musl
3 participants