Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a useless macro #428

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jan 13, 2021

This macro can be removed and its code can be inserted in the relative trait's method.

@Luni-4 Luni-4 requested a review from marco-c January 13, 2021 15:13
@Luni-4 Luni-4 force-pushed the move-external-function branch from 5cbaf1c to 8d677ba Compare January 13, 2021 15:15
@Luni-4 Luni-4 changed the title Remove an unused macro Remove a useless macro Jan 13, 2021
@Luni-4 Luni-4 force-pushed the move-external-function branch 2 times, most recently from 1fa2c8e to 436fe28 Compare January 14, 2021 09:36
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jan 14, 2021

Depends no #427

@Luni-4 Luni-4 force-pushed the move-external-function branch from 436fe28 to d0288b3 Compare January 15, 2021 10:33
@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #428 (606e6b1) into master (d5a5572) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   23.27%   23.27%           
=======================================
  Files          45       45           
  Lines        5490     5490           
  Branches      804      804           
=======================================
  Hits         1278     1278           
  Misses       3689     3689           
  Partials      523      523           
Impacted Files Coverage Δ
src/macros.rs 54.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a5572...606e6b1. Read the comment docs.

@Luni-4 Luni-4 force-pushed the move-external-function branch from d0288b3 to 606e6b1 Compare January 15, 2021 16:42
@marco-c marco-c merged commit 0964609 into mozilla:master Jan 25, 2021
@Luni-4 Luni-4 deleted the move-external-function branch January 25, 2021 10:02
spacedragon pushed a commit to spacedragon/rust-code-analysis that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants