Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a useless package_windows_binary from CI #458

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Feb 8, 2021

This PR fixes #434

Here's the log to verify that works

@Luni-4 Luni-4 marked this pull request as draft February 8, 2021 14:18
@Luni-4 Luni-4 force-pushed the remove-strip-function branch from 8813a0c to fca2a0b Compare February 8, 2021 14:37
@Luni-4 Luni-4 force-pushed the remove-strip-function branch from fca2a0b to 7770db0 Compare February 8, 2021 14:43
@Luni-4 Luni-4 marked this pull request as ready for review February 8, 2021 14:44
@Luni-4 Luni-4 changed the title [WIP] Remove a useless package_windows_binary from CI Remove a useless package_windows_binary from CI Feb 8, 2021
@Luni-4 Luni-4 requested a review from marco-c February 8, 2021 14:44
@codecov-io
Copy link

Codecov Report

Merging #458 (7770db0) into master (a956fec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   24.92%   24.92%           
=======================================
  Files          45       45           
  Lines        5584     5584           
  Branches      817      817           
=======================================
  Hits         1392     1392           
  Misses       3648     3648           
  Partials      544      544           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a956fec...7770db0. Read the comment docs.

@marco-c marco-c merged commit d5514e4 into mozilla:master Feb 8, 2021
@Luni-4 Luni-4 deleted the remove-strip-function branch March 9, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the package_windows_binary task and generate zip files directly in the build_windows_release task
3 participants