Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tree-sitter-mozjs to v0.17 #535

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Mar 10, 2021

This PR bumps tree-sitter-mozjs to v0.17. The grammar had been changed, so it was necessary to change the code that handles elseifs to fix tests and then run the metrics-checker

@Luni-4 Luni-4 marked this pull request as draft March 10, 2021 11:09
@Luni-4 Luni-4 force-pushed the tree-sitter-mozjs branch from 65a5e01 to 5193eb6 Compare March 10, 2021 12:58
@Luni-4 Luni-4 marked this pull request as ready for review March 10, 2021 12:58
@Luni-4 Luni-4 requested a review from marco-c March 10, 2021 12:58
@marco-c marco-c mentioned this pull request Mar 10, 2021
@codecov-io
Copy link

Codecov Report

Merging #535 (5193eb6) into master (5717a23) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   25.71%   25.68%   -0.03%     
==========================================
  Files          45       45              
  Lines        5620     5625       +5     
  Branches      837      837              
==========================================
  Hits         1445     1445              
- Misses       3652     3657       +5     
  Partials      523      523              
Impacted Files Coverage Δ
src/checker.rs 36.36% <ø> (ø)
src/languages/language_mozjs.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5717a23...5193eb6. Read the comment docs.

@marco-c marco-c merged commit d190dea into mozilla:master Mar 10, 2021
@Luni-4 Luni-4 deleted the tree-sitter-mozjs branch March 10, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants