Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tree-sitter lib and grammars #595

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Mar 30, 2021

This PR pins tree-sitter lib and grammars to avoid having differences in metrics without noticing them.

@Luni-4 Luni-4 requested a review from marco-c March 30, 2021 12:20
@marco-c
Copy link
Collaborator

marco-c commented Mar 30, 2021

Looks good, but we need to do the same in the other Cargo.toml files we have around the repo.

I hope Dependabot will still notify us of updates.

@Luni-4 Luni-4 force-pushed the clean-up branch 2 times, most recently from 695eadf to eef17ec Compare March 30, 2021 13:13
@Luni-4 Luni-4 changed the title Pin up tree-sitter lib and grammars Pin tree-sitter lib and grammars Mar 30, 2021
@codecov-io
Copy link

Codecov Report

Merging #595 (eef17ec) into master (1bf2a82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   27.59%   27.59%           
=======================================
  Files          45       45           
  Lines        5779     5779           
  Branches      849      849           
=======================================
  Hits         1595     1595           
  Misses       3631     3631           
  Partials      553      553           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf2a82...eef17ec. Read the comment docs.

marco-c
marco-c previously approved these changes Mar 30, 2021
@marco-c marco-c merged commit 593b6d5 into mozilla:master Mar 30, 2021
@Luni-4 Luni-4 deleted the clean-up branch March 30, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants