Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support m-c macros where first argument is a declaration #611

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

calixteman
Copy link
Collaborator

It aims to fix:
https://bugzilla.mozilla.org/show_bug.cgi?id=1702411#c8
I regenerated mozcpp grammar using ts-cpp and ts-c from their master versions and in using ts 0.19.4.
Tell me if I should change something about versions here.

@calixteman calixteman force-pushed the qm_try branch 2 times, most recently from bfda612 to 1990b23 Compare April 8, 2021 16:38
@calixteman calixteman requested a review from marco-c April 8, 2021 16:39
@janvarga
Copy link

janvarga commented Apr 8, 2021

I would also add QM_WARNONLY_TRY_UNWRAP to the list.

@marco-c
Copy link
Collaborator

marco-c commented Apr 8, 2021

@calixteman LGTM, can you update the version of the package at

tree-sitter-mozcpp = { path = "./tree-sitter-mozcpp", version = "0.19.0" }
and at ?

This way CI will run RCA on all files in mozilla-central and will output a list of differences.

@calixteman calixteman force-pushed the qm_try branch 2 times, most recently from e0326d5 to 78ddda2 Compare April 8, 2021 18:44
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

Please update tree-sitter-mozcpp version in enums/Cargo.toml too

@marco-c marco-c merged commit 3eb241f into mozilla:master Apr 9, 2021
This was referenced Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants