Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to split minimal tests into distinct directories depending on metrics differences #623

Merged
merged 2 commits into from
May 11, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Apr 14, 2021

This PR adds to CI a script that splits minimal tests into distinct directories depending on metrics differences.

Advantages of this script:

  • A more precise subdivision of metrics in directories
  • Cross-platform

@Luni-4 Luni-4 requested a review from marco-c April 14, 2021 13:47
check-grammars-crates.sh Outdated Show resolved Hide resolved
@Luni-4 Luni-4 requested a review from marco-c April 15, 2021 12:27
@Luni-4 Luni-4 removed the request for review from marco-c April 15, 2021 15:36
@Luni-4 Luni-4 marked this pull request as draft April 15, 2021 21:36
@codecov-commenter
Copy link

Codecov Report

Merging #623 (b77f68c) into master (e88bca1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   53.30%   53.30%           
=======================================
  Files          45       45           
  Lines        3617     3617           
  Branches      861      861           
=======================================
  Hits         1928     1928           
  Misses       1127     1127           
  Partials      562      562           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88bca1...b77f68c. Read the comment docs.

@Luni-4 Luni-4 force-pushed the better-grep branch 2 times, most recently from be0c6a2 to 123a5c8 Compare April 20, 2021 21:50
@Luni-4 Luni-4 changed the title Improve grep search in the grammar-checker Add a script to split minimal tests into distinct directories depending on metrics differences Apr 20, 2021
@Luni-4 Luni-4 requested a review from marco-c April 20, 2021 21:53
@Luni-4 Luni-4 marked this pull request as ready for review April 20, 2021 21:53
Luni-4 added 2 commits April 21, 2021 15:49
This script splits minimal tests into distinct directories depending on
their metric differences
@marco-c marco-c merged commit 2531d02 into mozilla:master May 11, 2021
@Luni-4 Luni-4 deleted the better-grep branch May 17, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants