Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mdbook building on CI #670

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix mdbook building on CI #670

merged 1 commit into from
Sep 16, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Sep 15, 2021

This PR fixes the mdbook building on CI.

The search feature has been removed from mdbook, so building the tool with it leads to some dependency conflicts

marco-c
marco-c previously approved these changes Sep 15, 2021
@marco-c
Copy link
Collaborator

marco-c commented Sep 15, 2021

Could you write a better commit message?
"Fix documentation CI" doesn't explain what the problem is.

@Luni-4 Luni-4 changed the title Fix documentation CI Fix mdbook building on CI Sep 16, 2021
@Luni-4 Luni-4 requested a review from marco-c September 16, 2021 08:20
@marco-c
Copy link
Collaborator

marco-c commented Sep 16, 2021

The commit message still doesn't explain what the problem was and how it was fixed :P

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Sep 16, 2021

The commit message still doesn't explain what the problem was and how it was fixed :P

Ok, now it should be fixed :)

The `search` feature has been removed from mdbook, so building the tool
with it leads to some dependency conflicts
@marco-c marco-c merged commit 69ac2e3 into mozilla:master Sep 16, 2021
@Luni-4 Luni-4 deleted the fix-ci branch September 16, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants