-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move c_macros generation into the enums crate #676
Conversation
In this way macros for the C language are not generated during rust-code-analysis build
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 36.96% 36.98% +0.01%
==========================================
Files 47 49 +2
Lines 6262 6268 +6
Branches 934 933 -1
==========================================
+ Hits 2315 2318 +3
- Misses 3306 3309 +3
Partials 641 641
Continue to review full report at Codecov.
|
Can we remove the |
I would have done that in a following PR, but I can remove it in this PR |
Yes, thanks, I'd prefer that |
c50b053
to
b1bd95b
Compare
b1bd95b
to
55c0ae9
Compare
This looks good to me, @calixteman do you want to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. r+
Thanks for doing that.
c_macros
generation to theenums
crate in order to avoid recreating eachc_macro
file whenever therust-code-analysis
library is built.phf_set
with a const array