Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actix-rt #687

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Update actix-rt #687

merged 1 commit into from
Oct 25, 2021

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Oct 25, 2021

This PR updates actix-rt for the web server

@Luni-4 Luni-4 requested a review from marco-c October 25, 2021 08:28
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks exactly like 72317ce, which we had to revert in cdaeda2 since it actually broke the server.
Did you make sure this actually works now?

@calixteman
Copy link
Collaborator

And it'd nice to fix clippy issues before to have a green CI (but in another PR).
We should likely add an integration test to test the server.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Oct 25, 2021

This looks exactly like 72317ce, which we had to revert in cdaeda2 since it actually broke the server. Did you make sure this actually works now?

Tests are passing locally, how can I verify that the server won't be broken?

And it'd nice to fix clippy issues before to have a green CI (but in another PR). We should likely add an integration test to test the server.

Yep, we should

@marco-c
Copy link
Collaborator

marco-c commented Oct 25, 2021

Tests are passing locally, how can I verify that the server won't be broken?

First basic test: run it and see if it starts :P

@codecov-commenter
Copy link

Codecov Report

Merging #687 (da6b2eb) into master (9608b7f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   36.96%   36.96%           
=======================================
  Files          49       49           
  Lines        6266     6266           
  Branches      933      934    +1     
=======================================
  Hits         2316     2316           
  Misses       3309     3309           
  Partials      641      641           
Impacted Files Coverage Δ
rust-code-analysis-web/src/web/server.rs 60.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9608b7f...da6b2eb. Read the comment docs.

@marco-c marco-c merged commit f413996 into master Oct 25, 2021
@marco-c marco-c deleted the updateactix branch October 25, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants