Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enum_iterator #710

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Remove enum_iterator #710

merged 1 commit into from
Nov 26, 2021

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Nov 26, 2021

It is used only in mk_enum and the macro knows already its variants so it can be manually implemented.

It is used only in mk_enum and the macro knows already its variants so
it can be manually implemented.
@codecov-commenter
Copy link

Codecov Report

Merging #710 (f685fde) into master (a6fb78b) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
- Coverage   37.51%   37.49%   -0.03%     
==========================================
  Files          50       50              
  Lines        6333     6334       +1     
  Branches      941      941              
==========================================
- Hits         2376     2375       -1     
- Misses       3309     3311       +2     
  Partials      648      648              
Impacted Files Coverage Δ
src/langs.rs 90.00% <ø> (ø)
src/macros.rs 53.22% <25.00%> (-2.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6fb78b...f685fde. Read the comment docs.

Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Please add the updated enums/Cargo.lock too and we are ready to go for me!

Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes a dependency so r+ for me, thx for doing this.

@calixteman calixteman merged commit f79628f into mozilla:master Nov 26, 2021
@calixteman
Copy link
Collaborator

oh I missed Luni's comment (mid-air collision).
Please make another PR asap.

@lu-zero lu-zero deleted the leaner-rca branch November 26, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants