Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum and maximum implementation for the cognitive metric #713

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

giovannitangredi
Copy link
Contributor

This PR adds minimum and maximum value for the cognitive metric, the method used is similar to min and max for cyclomatic and Nexit metric, Tests were modified accordingly.
Partly resolving Issue #410 .

@Luni-4 Luni-4 requested a review from calixteman November 29, 2021 11:37
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for doing this.

@calixteman calixteman merged commit e9314cc into mozilla:master Nov 30, 2021
@Luni-4 Luni-4 deleted the min-max-metrics branch November 30, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants