Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum and maximum implementation for Nargs #715

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

giovannitangredi
Copy link
Contributor

This PR adds minimum and maximum value for the Nargs metric, the method used is similar to min and max for precedent metrics, Tests were modified accordingly.
Partly resolving Issue #410 .

@codecov-commenter
Copy link

Codecov Report

Merging #715 (e96ec73) into master (e9314cc) will increase coverage by 0.21%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   37.73%   37.95%   +0.21%     
==========================================
  Files          50       50              
  Lines        6384     6429      +45     
  Branches      945      949       +4     
==========================================
+ Hits         2409     2440      +31     
- Misses       3323     3333      +10     
- Partials      652      656       +4     
Impacted Files Coverage Δ
rust-code-analysis-web/src/web/server.rs 60.54% <ø> (ø)
src/metrics/nargs.rs 74.41% <66.03%> (-1.29%) ⬇️
src/spaces.rs 66.09% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9314cc...e96ec73. Read the comment docs.

Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thx.

@calixteman calixteman merged commit 58b0ac2 into mozilla:master Dec 2, 2021
@Luni-4 Luni-4 deleted the min-max-metrics branch December 2, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants