-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more integration tests #724
Conversation
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
+ Coverage 39.11% 39.39% +0.28%
==========================================
Files 51 51
Lines 6809 6810 +1
Branches 972 972
==========================================
+ Hits 2663 2683 +20
+ Misses 3477 3460 -17
+ Partials 669 667 -2
Continue to review full report at Codecov.
|
Might be better to avoid storing all the expected JSON files in the repo, but run RCA before/after a change like we do for mozilla-central integration tests. |
1372a62
to
67d2cf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me! Thank you!
08968ed
to
90f834e
Compare
28fac6e
to
95ac445
Compare
6e1ac82
to
fd706fb
Compare
fd706fb
to
3c9f992
Compare
This PR adds DeepSpeech and grcov as git submodules, their json metrics files and 2 integration tests.
The tests compare rca output for the submodules with their json files previously generated.
To do that I used the APIs to process files in a directory concurrently introduced here: #709
It partly resolves issue #389