Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more integration tests #724

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

marco-ballario
Copy link
Contributor

@marco-ballario marco-ballario commented Dec 15, 2021

This PR adds DeepSpeech and grcov as git submodules, their json metrics files and 2 integration tests.
The tests compare rca output for the submodules with their json files previously generated.
To do that I used the APIs to process files in a directory concurrently introduced here: #709
It partly resolves issue #389

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #724 (fd706fb) into master (4d7f6b2) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   39.11%   39.39%   +0.28%     
==========================================
  Files          51       51              
  Lines        6809     6810       +1     
  Branches      972      972              
==========================================
+ Hits         2663     2683      +20     
+ Misses       3477     3460      -17     
+ Partials      669      667       -2     
Impacted Files Coverage Δ
src/tools.rs 54.77% <100.00%> (+0.22%) ⬆️
src/metrics/cognitive.rs 71.75% <0.00%> (+0.32%) ⬆️
src/spaces.rs 71.34% <0.00%> (+2.43%) ⬆️
src/concurrent_files.rs 3.47% <0.00%> (+3.47%) ⬆️
src/getter.rs 75.21% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7f6b2...fd706fb. Read the comment docs.

.gitmodules Outdated Show resolved Hide resolved
@marco-c
Copy link
Collaborator

marco-c commented Dec 17, 2021

Might be better to avoid storing all the expected JSON files in the repo, but run RCA before/after a change like we do for mozilla-central integration tests.
Another option would be to store all the JSON in a separate repository that we clone at the time of the integration tests, this way we don't need to store all these JSON files in this repository.

@marco-ballario marco-ballario force-pushed the integration-tests branch 18 times, most recently from 1372a62 to 67d2cf5 Compare December 23, 2021 13:31
@Luni-4 Luni-4 requested a review from marco-c December 23, 2021 13:34
Luni-4
Luni-4 previously approved these changes Dec 23, 2021
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! Thank you!

src/tools.rs Show resolved Hide resolved
src/concurrent_files.rs Outdated Show resolved Hide resolved
tests/test.rs Outdated Show resolved Hide resolved
@marco-ballario marco-ballario force-pushed the integration-tests branch 3 times, most recently from 08968ed to 90f834e Compare January 14, 2022 01:43
@marco-ballario marco-ballario force-pushed the integration-tests branch 2 times, most recently from 6e1ac82 to fd706fb Compare January 14, 2022 20:37
src/tools.rs Show resolved Hide resolved
@marco-c marco-c merged commit 97d07e1 into mozilla:master Jan 19, 2022
@Luni-4 Luni-4 deleted the integration-tests branch January 19, 2022 11:21
@marco-c marco-c linked an issue Jan 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more integration tests for the lib
4 participants