Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add averages for Loc metrics #737

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

marco-ballario
Copy link
Contributor

This PR adds some averages calculations for the Loc metrics. Averages are calculated over spaces, like for the Cyclomatic metric. Tests have been updated accordingly. This PR should partly resolve issue #409 . Thanks in advance for the review.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #737 (aa59854) into master (f9c1454) will increase coverage by 0.94%.
The diff coverage is 89.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   37.95%   38.90%   +0.94%     
==========================================
  Files          51       51              
  Lines        6549     6683     +134     
  Branches      963      968       +5     
==========================================
+ Hits         2486     2600     +114     
- Misses       3403     3418      +15     
- Partials      660      665       +5     
Impacted Files Coverage Δ
rust-code-analysis-web/src/web/server.rs 61.81% <ø> (ø)
src/metrics/loc.rs 79.90% <89.78%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c1454...aa59854. Read the comment docs.

calixteman
calixteman previously approved these changes Jan 10, 2022
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman
Copy link
Collaborator

Please rebase.

@calixteman calixteman merged commit 1c3c663 into mozilla:master Jan 11, 2022
@Luni-4 Luni-4 deleted the average-loc branch January 11, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants