Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minimum and maximum implementation for Loc #793

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

giovannitangredi
Copy link
Contributor

This PR adds minimum and maximum value for the Loc metric.

Given the high number of fields the Sloc, Ploc, Cloc and Lloc substructs have been created to make the code more readable.
Partly resolving Issue #410 .

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #793 (d9cacf4) into master (98538cb) will increase coverage by 0.94%.
The diff coverage is 79.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   39.63%   40.57%   +0.94%     
==========================================
  Files          51       51              
  Lines        6827     6999     +172     
  Branches      975      990      +15     
==========================================
+ Hits         2706     2840     +134     
- Misses       3453     3481      +28     
- Partials      668      678      +10     
Impacted Files Coverage Δ
rust-code-analysis-web/src/web/server.rs 61.81% <ø> (ø)
src/metrics/exit.rs 74.77% <0.00%> (ø)
src/metrics/loc.rs 79.55% <79.64%> (-0.74%) ⬇️
rust-code-analysis-web/src/main.rs 5.26% <100.00%> (ø)
src/spaces.rs 71.51% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98538cb...d9cacf4. Read the comment docs.

@Luni-4 Luni-4 requested a review from calixteman March 3, 2022 15:50
Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me.
Thank you for doing this.

@marco-c marco-c merged commit 97e576b into mozilla:master Mar 18, 2022
@Luni-4 Luni-4 deleted the min-max-metrics branch March 18, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants