fix: hanging server #806
Merged
fix: hanging server #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the update to actix-rt@2.3 (f413996), the web server hasn't been started, when we executed `cargo run -p rust-code-analysis-web`. It froze once `actix_rt::System::new().run()?;` was called, effectively preventing the execution of the code below. By looking at the actix-rt examples and changing the code to be more like the examples, I was able to fix this. The webserver now behaves as expected.
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 40.74% 41.04% +0.30%
==========================================
Files 51 51
Lines 7020 7016 -4
Branches 991 988 -3
==========================================
+ Hits 2860 2880 +20
+ Misses 3481 3463 -18
+ Partials 679 673 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the update to actix-rt@2.3 (f413996), the web server hasn't been
started, when we executed
cargo run -p rust-code-analysis-web.It froze once
actix_rt::System::new().run()?;was called,effectively preventing the execution of the code below.
By looking at the actix-rt examples and changing the code to be more
like the examples, I was able to fix this.
The webserver now behaves as expected.