Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds exit metrics #822

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

dburriss
Copy link
Contributor

@dburriss dburriss commented Apr 12, 2022

  • Implement nom as needed for this metric (i think looking at htis:
    state.space.metrics.nexits.finalize(nom_total);
    )
  • Implementation
  • Tests (some done during development but probably should add another 1 or 2)

before exit metric

after exit metric

@dburriss dburriss force-pushed the dburriss/feature/issue-359/java-exit branch from 5fb2e63 to 7f6f44a Compare April 14, 2022 15:11
@dburriss dburriss force-pushed the dburriss/feature/issue-359/java-exit branch from 7f6f44a to a2fec86 Compare April 15, 2022 05:47
@dburriss dburriss marked this pull request as ready for review April 15, 2022 05:50
@dburriss
Copy link
Contributor Author

@marco assuming all checks pass this is ready for review.

@codecov-commenter
Copy link

Codecov Report

Merging #822 (a2fec86) into master (7b9d158) will increase coverage by 0.07%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   41.02%   41.10%   +0.07%     
==========================================
  Files          51       51              
  Lines        7100     7116      +16     
  Branches     1013     1017       +4     
==========================================
+ Hits         2913     2925      +12     
- Misses       3485     3486       +1     
- Partials      702      705       +3     
Impacted Files Coverage Δ
src/metrics/exit.rs 75.38% <81.25%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9d158...a2fec86. Read the comment docs.

Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c marco-c merged commit f3b5dc1 into mozilla:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants