Java nom metrics #823
Merged
Java nom metrics #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dburriss
force-pushed
the
dburriss/feature/issue-359/java-nom
branch
from
b0de32c to
13a21e8
Compare
marco-c
previously approved these changes
Apr 14, 2022
Yeah... turns out lambdas in Java are really ugly :) |
marco-c
reviewed
Apr 14, 2022
src/metrics/nom.rs
Outdated
| @@ -123,6 +123,7 @@ impl Stats { | |||
| /// Returns the average number of function definitions over all spaces | |||
| #[inline(always)] | |||
| pub fn functions_average(&self) -> f64 { | |||
| println!("SPACE {}", self.space_count); | |||
There was a problem hiding this comment.
Please remove the debugging statement ;)
There was a problem hiding this comment.
Bah! Forgot about it. Done.
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 40.92% 41.03% +0.10%
==========================================
Files 51 51
Lines 7088 7101 +13
Branches 1011 1013 +2
==========================================
+ Hits 2901 2914 +13
+ Misses 3486 3485 -1
- Partials 701 702 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
LambdaExpressionto theCheckeris_closureand adds a test for Java nom metric.