Cognitive complexity metric for Java

[dburriss]

Last metric for #359

• Implementation
• All tests pass
• Branch up-to-date
• Cleanup

Tests and API have changed a fair bit since I started work on this so tracking some additional tasks:

• update API usage to accommodate changes
• redo tests with Insta
• figure out why average not working (something to do with space functions I think)

[marco-c]

@dburriss any plans to finish this?

[dburriss]

Hi @marco-c
Sorry was job hunting and then ramping up so didn't have much energy for this. I'll try dive into this again tomorrow morning now that things have settled.

[Luni-4]

Hello @dburriss, thank you for your hard work!

I think that if you insert test methods inside a class, you would get the correct average value. Something like this:

class X {
     public static void print(boolean a, boolean b, boolean c, boolean d){  // +1
         if (a && !(b && c)) { // +3 (+1 &&, +1 &&)
             printf(\"test\");
         }
     }
}

[dburriss]

Hi @Luni-4
Thanks for the suggestion. I'll give that a try.

[Luni-4]

Hi @Luni-4 Thanks for the suggestion. I'll give that a try.

It worked!

[dburriss]

@marco-c @Luni-4 It looks like this is finally ready for a second pair of eyes.

[Luni-4]

Thank you @dburriss! Just simple things from my side:

• we need to remove the Cargo.lock file since it is no longer necessary
• we need to replace Boolean with boolean in Java functions

[dburriss]

@Luni-4 thanks for the review. I have made the requested improvements.

[Luni-4]

Thank you @dburriss! Just simple things again

[Luni-4]

Ok, last change and we are ready to merge in!

[dburriss]

@marco-c the task expired before a worker was made available for the checks. Should I push another commit to trigger or is there an issue (and trying again could make it worse).

[marco-c]

I retriggered it manually and it passed.

[Luni-4]

It's fine for me! Thanks a lot @dburriss!

[dburriss]

@marco-c the steps that had not run passed but the rest were in an exception state due to timeout exceeded. Triggered a check with a commit.
@Luni-4 I updated a comment to get the check to run. You may want to check it since I've got those wrong before :p

[Luni-4]

@dburriss Your last commit is fine as well for me! Thank you!