Make id and root public in AstNode #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luni-4
approved these changes
Aug 18, 2022
|
Some clippy errors are blocking this merge. Should be fixed by #913. |
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
==========================================
- Coverage 68.55% 68.54% -0.01%
==========================================
Files 60 60
Lines 12297 12297
==========================================
- Hits 8430 8429 -1
- Misses 3867 3868 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use
rust-code-analysisas a library. I can't access the node in the result ofAstCallback. The hack-y way is to serialize and deserialize to void the access check, but this should be public.