Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cargo.lock only to the release job #958

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Add Cargo.lock only to the release job #958

merged 3 commits into from
Dec 20, 2022

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Dec 12, 2022

Cargo.lock causes many dependencies issues during a development and more in general causes to waste 2x the development time because it makes difficult the rebase operation.

For these reasons, we have added it only to the release job

@Luni-4 Luni-4 requested a review from marco-c December 12, 2022 16:35
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Dec 12, 2022

Blocked by #954

@Luni-4 Luni-4 removed the request for review from marco-c December 12, 2022 16:43
marco-c
marco-c previously approved these changes Dec 12, 2022
@marco-c
Copy link
Collaborator

marco-c commented Dec 20, 2022

There is one case where this is really useful: being notified of tree-sitter updates so we can check that there are no regressions with our integration tests.

Currently, in Cargo.toml we have tree-sitter = ">= 0.20, < 0.21" and so dependabot only checks Cargo.lock for new patch versions. Here's an example PR from dependabot: #922.

Maybe the best solution would be to remove Cargo.lock but force a specific tree-sitter version in Cargo.toml, so we can still rely on dependabot to notify us of new versions and we can run integration tests before upgrading.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 68.13% // Head: 68.14% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8213bea) compared to base (524449d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   68.13%   68.14%           
=======================================
  Files          60       60           
  Lines       12342    12342           
=======================================
+ Hits         8409     8410    +1     
+ Misses       3933     3932    -1     
Impacted Files Coverage Δ
src/metrics/abc.rs 94.32% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marco-c marco-c merged commit 25ce2d2 into master Dec 20, 2022
@marco-c marco-c deleted the remove-cargo-lock branch December 20, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants