-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 .deb and .rpm builds #891
Conversation
There is a GPG related test failing, which I think has nothing to do with my changes. |
See #882 about the tests. |
Once there are arm64 go-binaries, I'd like to update the asdf plugin for sops to detect the host OS before installing https://github.com/feniix/asdf-sops |
Is something blocking the merge? |
I'm in favor of this and would like to get it merged before the next release. Paired with #911 this gets us to arm64 support for all of our release packages. But, we have started moving to using .github/workflows/release.yml so changes will also need to be made there. |
@ajvb I continue to want to ship this, and can make modifications if necessary. But I'm not completely sure of what I need to change? Turning the Makefile based building into Github Actions based building? |
My apologies @FnTm, I messed up. This PR looks great as-is. Would you mind merging |
@nklmilojevic Next week or the following. |
@ajvb done, but I'm not seeing tests being run. It seems like approval is needed for the tests to be run: |
Thank you again @FnTm! |
Absolutely, and thank you for taking over and ensuring SOPS continues to
live :)
…On Fri, Mar 4, 2022, 20:37 AJ Bahnken ***@***.***> wrote:
Thank you again @FnTm <https://github.com/FnTm>!
—
Reply to this email directly, view it on GitHub
<#891 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHW6XOBGXZZAVECNOWXLA3U6JJ5FANCNFSM47EPC5KA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I needed the ability to install arm64 based sops in a multi-arch Docker image, thus this PR adds the ability for the release process to generate arm64 .deb and .rpm builds.
May be a bit of an overkill with the Makefile variables, but that could make adding more architectures more DRY in the future.
I'm not a Go or Makefile expert by any stretch, but technically this seems to work, and I've verified this by installing arm64 builds in an arm64 Docker image.
This PR does not add arm64 support for sops Dockerhub images.
Fixes #595