-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to initialize mappings wasm via ArrayBuffer #339
Conversation
Pull Request Test Coverage Report for Build 491
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait -- before we merge this, can you add a small test for initializing with an array buffer? Thanks!
I was going to, but with the existing test tooling, there's no way to write a test for this because Do you have an opinion regarding how browser testing should be done? |
Bleh, I overlooked that. We would need some kind of headless browser testing setup. If you want to dig into adding that, please be my guest :) In the meantime, we can just merge this. Thanks again! |
Can you rebase this branch on master? |
7cf7e82
to
6e618f5
Compare
Just did, thanks! 😄 |
This PR adds the ability to directly pass in the mappings wasm into
SourceMapConsumer.initialize
. This is needed for browser usage without needing to make a request (e.g. needing to work around CSP restrictions).Example
I didn't implement this because it would be a breaking change, but I think a better alternative API might be something like: