Pass through the implementation of more index map operations. #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexed maps have a lot of duplication with basic maps right now, and I can't see a good reason for it, so this is an effort to normalize all of that logic on top of the basic map implementation.
This PR also includes support for
computeColumnSpans
on indexed maps, so that the two types of consumers have a consistent API again.Beyond the expected stuff, this PR also includes one breaking change. The basic consumer's
eachMapping
function now returnslastGeneratedColumn
asInfinity
instead ofnull
when you've calledcomputeColumnSpans
and there was no span end. Before this, it wasnull
, but setting it toInfinity
keeps the API consistent withgeneratedPositionFor
andallGeneratedPositionsFor
'slastColumn
value.