Normalize all URLs to be as absolute as possible to avoid usage of 'util.relative'. #366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consumer currently uses
util.relative
to take a URL and convert it to one that may be present in_sources
. There are a few downsides to this approach:sources
or else risk not finding the matchsources
conform to the expectation of relative URLsrelative
makes it unclear whether argument URLs are expected to be relative to the map, or the root, or either.sources: ['/a.js']
(which is also only special-cased on insourceContentFor
)This patch centralizes all source lookups for the consumer in
_findSourceIndex
so that all APIs behave consistently. By converting all input paths to be as absolute as we can make them, we avoid the complexities of making URLs relative to one another, and it helps make clear how these behave.