Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

position on passwordrules proposal #402

Merged
merged 2 commits into from
Jul 23, 2020
Merged

position on passwordrules proposal #402

merged 2 commits into from
Jul 23, 2020

Conversation

linuxwolf
Copy link
Contributor

Closes #61, based on my reading.

annevk
annevk approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

martinthomson
martinthomson approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a maxLength? You would think that would have to have a minimum...

tantek
tantek approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, accurately reflects #61.

@dbaron dbaron merged commit f5aa71c into mozilla:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

@martinthomson martinthomson martinthomson approved these changes

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML: passwordrules attribute
5 participants
@linuxwolf @tantek @martinthomson @annevk @dbaron