Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out github-pull-request events don't run builds on irrelevant ones #396

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

lotas
Copy link
Contributor

@lotas lotas commented Sep 27, 2023

I noticed that mozilla/task-boot is not filtering pull request events, which results in builds for such events like:

  • pull_request.edited
  • pull_request.ready_for_review
  • pull_request.converted_to_draft
  • pull_request.review_requested
  • pull_request.auto_merge_enabled

We only want opened, reopened and synchronize events

Here's what it looks like in debug tool: existing .taskcluster.yml
and here's how for updated .taskcluster.yml

@marco-c marco-c linked an issue Sep 27, 2023 that may be closed by this pull request
.taskcluster.yml Outdated Show resolved Hide resolved
.taskcluster.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is only a 4 lines diff now (after hiding whitespace changes).

@marco-c marco-c merged commit bd37ee3 into mozilla:master Sep 28, 2023
1 check passed
@lotas lotas deleted the chore/tc-yml branch September 28, 2023 13:04
@lotas
Copy link
Contributor Author

lotas commented Sep 28, 2023

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run CI on PR closure
2 participants