add new_failure field to TextLogError and update when we have a… #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaher
force-pushed
the
newfailure
branch
5 times, most recently
from
46547a8
to
9bae67c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8254 +/- ##
==========================================
+ Coverage 77.16% 77.18% +0.01%
==========================================
Files 550 551 +1
Lines 27104 27123 +19
Branches 3361 3361
==========================================
+ Hits 20915 20935 +20
+ Misses 6028 6027 -1
Partials 161 161 ☔ View full report in Codecov by Sentry. |
jmaher
force-pushed
the
newfailure
branch
2 times, most recently
from
4fa2180
to
5d075df
Compare
jmaher
commented
Oct 21, 2024
| @@ -30,6 +30,9 @@ def store_text_log_summary_artifact(job, text_log_summary_artifact): | |||
| ignore_conflicts=True, | |||
| ) | |||
|
|
|||
| # Bulk create doesn't return .id field, so query to get them. | |||
| log_errors = TextLogError.objects.filter(job=job) | |||
There was a problem hiding this comment.
note, this could be a perf impact, we could reconsider this specific approach, maybe only do this if we have a need to update, or convert bulk_create -> save() in a loop
jmaher
commented
Oct 21, 2024
| for tle in log_errors: | ||
| if tle.line_number == suggestion["line_number"]: | ||
| tle.new_failure = True | ||
| tle.save(update_fields=["new_failure"]) |
There was a problem hiding this comment.
using update_fields is a perf win, so I get a little bit of a win here for the existing code :)
jmaher
changed the title
Archaeopteryx
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… new failure.
need to do: