Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused RustBuffer.rs scaffolding template #1725

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Remove unused RustBuffer.rs scaffolding template #1725

merged 1 commit into from
Sep 6, 2023

Conversation

mhammond
Copy link
Member

Apparently this template is no longer used, but it confused me when I tried to modify it.

@mhammond mhammond requested a review from bendk August 29, 2023 21:09
@mhammond mhammond requested a review from a team as a code owner August 29, 2023 21:09
bendk
bendk approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @badboy, will this affect you work in #1718?

@badboy
Copy link
Member

badboy commented Sep 5, 2023

Looks good to me. @badboy, will this affect you work in #1718?

Good question. I did not have the time to finalize my work on that yet, but will do so this week.

badboy
badboy approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Its use was removed in f847c32. The macros now generate this scaffolding inline.
It won't affect my work on the no_mangle stuff.

@badboy badboy merged commit b5e500b into mozilla:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendk bendk bendk approved these changes

@badboy badboy badboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhammond @badboy @bendk