RustCallStatus::error_buf is now ManuallyDrop and not MaybeUninit.
#2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
push-pkvpppluwwzk
branch
from
a9fdfaf to
a47e239
Compare
badboy
approved these changes
Jul 1, 2024
bendk
approved these changes
Jul 1, 2024
`error_buf` is owned by the foreign side. Because we assume it has been initialized we use `ManuallyDrop` instead of `MaybeUninit`, which clarifies ownership and avoids unsafe code. Fixes mozilla#2168
mhammond
force-pushed
the
push-pkvpppluwwzk
branch
from
a47e239 to
8246909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error_bufis owned by the foreign side. Because we assume it has been initialized we useManuallyDropinstead ofMaybeUninit, which clarifies ownership and avoids unsafe code.Fixes #2168