Allow UDL to avoid the [Rust=...] attribute by using a plain-old ty…
#2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
push-ukorpwrxznzy
branch
from
4ecbac7 to
1e53592
Compare
badboy
reviewed
Jul 30, 2024
badboy
reviewed
Jul 30, 2024
mhammond
force-pushed
the
push-ukorpwrxznzy
branch
2 times, most recently
from
c30c046 to
d9dd9ff
Compare
mhammond
commented
Jul 30, 2024
| name, | ||
| }, | ||
| "custom" => panic!("don't know builtin"), | ||
| "interface" | "impl" => Type::Object { |
There was a problem hiding this comment.
I should call out that I added a couple of names compared to the Rust attribute. In particular, struct as an alias for record above, and impl as an alias for interface here. My thinking was that these names more closely match what a Rust programmer is likely to think of - ie, a derive(uniffi::Record) lives on a struct defn while uniffi::export lives on an impl block.
On the negative side, impl is also used for traits.
I personally quite like these names, but don't feel too strongly about it, so will happily concede to someone who strongly dislikes them!
mhammond
force-pushed
the
push-ukorpwrxznzy
branch
2 times, most recently
from
34baacc to
b600a0b
Compare
bendk
approved these changes
Aug 2, 2024
| name, | ||
| }, | ||
| "custom" => panic!("don't know builtin"), | ||
| "interface" | "impl" => Type::Object { |
mhammond
force-pushed
the
push-ukorpwrxznzy
branch
from
b600a0b to
032e873
Compare
|
Note that I snuck in a change to move a previously misplaced CHANGELOG entry here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pedef
This is a WIP and needs a little cleaning up, but thought I'd throw it out there. It allows people to stop using the
[Rust=...]attribute in UDL.This doesn't seem that interesting now, but it will really make sense once Ben's other work lands and we could take this further and use it with
[External](to, eg, drop the entireExternalInterfaceattribute) and with[Remote].