Future cancellation docs and other minor doc tweaks. #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
approved these changes
Aug 7, 2024
| @@ -8,9 +8,9 @@ The next step is to have UniFFI generate source code for your foreign language. | |||
|
|
|||
| First, make sure you have installed all the [prerequisites](./Prerequisites.md). | |||
|
|
|||
| Ideally you would then run the `uniffi-bindgen` binary from the `uniffi` crate to generate your bindings. However, this | |||
There was a problem hiding this comment.
These changes and below seem unrelated to this specific PR?
Intentionally?
Fine with me to land them along if it is.
There was a problem hiding this comment.
Yep, it was intentional, I had some other doc changes queued up which weren't worth their own PR
Co-authored-by: Jan-Erik Rediger <janerik@fnordig.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some minor doc tweaks stacked up, then saw @bendk's matrix notes re async cancellation, so might as well get em all in.