feat: Add missing namespaces to metadata #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto-generated output from the metadata generator also includes the
following methods from Chrome. Firefox does not support them, so they
were not included in the metadata:
```
"removeAppcache": {
"minArgs": 1,
"maxArgs": 1
},
"removeFileSystems": {
"minArgs": 1,
"maxArgs": 1
},
"removeIndexedDB": {
"minArgs": 1,
"maxArgs": 1
},
"removeWebSQL": {
"minArgs": 1,
"maxArgs": 1
},
```
Also see:
https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/browser/components/extensions/schemas/browsing_data.json
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browsingData#Browser_compatibility
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/sessions#Browser_compatibility Only `sessions.getRecentlyClosed` and `sessions.restore` are currently supported by Firefox. `sessions.getDevices` is included anyway since this method may be added to Firefox in the future: https://bugzil.la/1308059
This was referenced Jun 15, 2018
notlmn
added a commit
to sindresorhus/notifier-for-github
that referenced
this pull request
Jul 25, 2018
Closes #155, and #156 webextension-polyfill had most of the APIs to be promise based, but some of them (like permissions API) were only promisified in mozilla/webextension-polyfill#126 and broke the extension I was too lazy to see webextion-polyfill packages release notes before updating to a newer version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at the list of namespaces from #122 (comment) and added those which were missing to the metadata.
See the individual commit messages for more information.
With this PR (and #125), the metadata should be up-to-date, except for the
privacynamespace.Fixes #38