Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made compatible with Edge browser #61

Closed
wants to merge 1 commit into from
Closed

Conversation

mi-g
Copy link

@mi-g mi-g commented Oct 1, 2017

Detect the need to wrap the API even if global 'browser' object is defined (case of Edge) but methods do not support returning promises.
Adapt wrapping to Edge specificities.

@mi-g
Copy link
Author

mi-g commented Oct 3, 2017

This PR has 3 errors in Travis CI.
I believe the tests have to be reworked. For instance, the failed test "browser-polyfill does (not) override the global browser namespace if it already exists" is definitely wrong: Edge has a 'browser' global that has to be overridden. I'm unsure about the other 2 but the PR leaves the wrapping unchanged in case of Chrome browser.

@ExE-Boss
Copy link
Contributor

I’ve added tests to cover the specific issues in #114.

@rpl
Copy link
Member

rpl commented Jun 21, 2018

Closing in favor of #114 (which is still exploring how we may allow the polyfill to work on Edge, and it is also taking advantage of the recently added integration tests to ensure that the additional changes needed are not going to break the polyfill behaviors expected on Chrome and Firefox).

@rpl rpl closed this Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants