Check that engine types don't already match before setting a new engi…

…ne type.
mpaperno · Aug 16, 2023 · c364fbd · c364fbd
1 parent f0e6d81
commit c364fbd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/canvas.rs b/src/canvas.rs
@@ -80,9 +80,11 @@ pub fn get_engine(mut cx: FunctionContext) -> JsResult<JsString> {
 pub fn set_engine(mut cx: FunctionContext) -> JsResult<JsUndefined> {
   let this = cx.argument::<BoxedCanvas>(0)?;
   if let Some(engine_name) = opt_string_arg(&mut cx, 1){
-    if let Some(new_engine) = to_engine(&engine_name){
-      if new_engine.supported() {
-        this.borrow_mut().engine = new_engine
+    if let Some(new_engine) = to_engine(&engine_name) {
+      if new_engine != this.borrow().engine {
+        if new_engine.supported() {
+          this.borrow_mut().engine = new_engine
+        }
       }
     }
   }

diff --git a/src/gpu/mod.rs b/src/gpu/mod.rs
@@ -30,6 +30,7 @@ pub use crate::gpu::metal::autoreleasepool as runloop;
 pub fn runloop<T, F: FnOnce() -> T>(f: F) -> T { f() }
 
 #[derive(Copy, Clone, Debug)]
+#[derive(PartialEq)]
 pub enum RenderingEngine{
     CPU,
     GPU,