Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send ProductName to Braze #174

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat: Send ProductName to Braze #174

merged 3 commits into from
Nov 13, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Right now, in Android, we send product SKUs to Braze. The product name should also be sent for the native kits, just like we do for the Web kit. If a setting is enabled, the product name should be sent; otherwise, the SKU should be sent to Braze.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with the sample app and executed unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle merged commit fb6bbba into development Nov 13, 2024
16 checks passed
@Mansi-mParticle Mansi-mParticle deleted the feat/SQDSDKS-6888-send-product-name branch November 13, 2024 18:53
einsteinx2 pushed a commit that referenced this pull request Dec 12, 2024
@Mansi-mParticle @einsteinx2
feat: Send ProductName to Braze (#174)
5d9ce41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdozor samdozor samdozor left review comments

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@rmi22186 rmi22186 Awaiting requested review from rmi22186

@BrandonStalnaker BrandonStalnaker Awaiting requested review from BrandonStalnaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mansi-mParticle @einsteinx2 @samdozor