feat: Update Leanplum SDK to Version 6.x #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jasonmgeorge
reviewed
Nov 6, 2023
mParticle-Leanplum.podspec
Outdated
| @@ -16,7 +16,7 @@ Pod::Spec.new do |s| | |||
| s.ios.deployment_target = "9.0" | |||
| s.ios.source_files = 'mParticle-Leanplum/*.{h,m,mm}' | |||
| s.ios.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.0' | |||
| s.ios.dependency 'Leanplum-iOS-SDK', '~> 4.1' | |||
| s.ios.dependency 'Leanplum-iOS-SDK', '~> 6.0' | |||
There was a problem hiding this comment.
Any reason not to align on 6.1 here?
There was a problem hiding this comment.
@jasonmgeorge It'll automatically take anything up to 6.x with this. I could put 6.1 to make that the minimum but I think keeping it .0 helps people remember the "up to next major version" bit better
There was a problem hiding this comment.
It would make sense to be aligned with the others, though. No?
There was a problem hiding this comment.
@via-guy agreed, we should either change this one to 6.1 or change the others to 6.0 and 6.0.0 respectively
einsteinx2
requested changes
Nov 8, 2023
mParticle-Leanplum.podspec
Outdated
| @@ -16,7 +16,7 @@ Pod::Spec.new do |s| | |||
| s.ios.deployment_target = "9.0" | |||
| s.ios.source_files = 'mParticle-Leanplum/*.{h,m,mm}' | |||
| s.ios.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.0' | |||
| s.ios.dependency 'Leanplum-iOS-SDK', '~> 4.1' | |||
| s.ios.dependency 'Leanplum-iOS-SDK', '~> 6.0' | |||
There was a problem hiding this comment.
@via-guy agreed, we should either change this one to 6.1 or change the others to 6.0 and 6.0.0 respectively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)