fix:send default and update consent payloads on kit init #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
reviewed
Oct 1, 2024
Comment on lines
1268
to
+1270
| window.dataLayer[0][0].should.equal('consent'); | ||
| window.dataLayer[0][1].should.equal('default'); | ||
| window.dataLayer[0][2].should.deepEqual(expectedDataLayer[2]); | ||
| window.dataLayer[0][2].should.deepEqual(expectedDataLayer1[2]); |
There was a problem hiding this comment.
I had similar feedback for alex here - you can probably refactor these 2 checks for the [0] and [1] index to be something like:
window.dataLayer[0].should.deepEqual(expectedDataLayer1)
window.dataLayer[1].should.deepEqual(expectedDataLayer2)
Comment on lines
+1504
to
+1513
| window.dataLayer.length.should.eql(2); | ||
| window.dataLayer[0][0].should.equal('consent'); | ||
| window.dataLayer[0][1].should.equal('default'); | ||
| window.dataLayer[0][2].should.deepEqual( | ||
| expectedDataLayerBefore[2] | ||
| expectedDataLayerBefore1[2] | ||
| ); | ||
| window.dataLayer[1][0].should.equal('consent'); | ||
| window.dataLayer[1][1].should.equal('update'); | ||
| window.dataLayer[1][2].should.deepEqual( | ||
| expectedDataLayerBefore2[2] |
There was a problem hiding this comment.
same comment about doing deepEqual to the full object
Comment on lines
+1570
to
1573
| window.dataLayer[2][0].should.equal('consent'); | ||
| window.dataLayer[2][1].should.equal('update'); | ||
| window.dataLayer[2][2].should.deepEqual( | ||
| expectedDataLayerAfter[2] |
Comment on lines
+1639
to
1643
| window.dataLayer.length.should.eql(4); | ||
| window.dataLayer[3][0].should.equal('consent'); | ||
| window.dataLayer[3][1].should.equal('update'); | ||
| window.dataLayer[3][2].should.deepEqual( | ||
| expectedDataLayerFinal[2] |
|
discussed with mo that the depe equal doesn't work bc of one being an arguments, and another being an array. there is no shallow equals in mocha/chai, but we can probably update this in the future when we do a migration to TS/jest. |
rmi22186
approved these changes
Oct 1, 2024
rmi22186
pushed a commit
that referenced
this pull request
Oct 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
## [2.3.2](v2.3.1...v2.3.2) (2024-10-02) ### Bug Fixes * send default and update consent payloads on kit init ([#58](#58)) ([200b918](200b918))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)