fix: Revise PR Github Action, Update testing framework and Lint Files #40
Conversation
| npx semantic-release | ||
|
|
||
| - name: Archive npm failure logs | ||
| uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
thanks for remembering to make this v4!
| @@ -0,0 +1,14 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
I noticed you didn't include dependabot files in a previous CI/CD update. Including it will just result in a ton of spam from testing dependencies. Decisio is yours, but my thoughts are to remove and reconsider when we have a new forwarder ecosystem architecture.
There was a problem hiding this comment.
Since this is an older repo, we have a lot of backlogged dependabot updates. My thought was to include the dependabot yml from Web SDK that isolates the main/master branch, limits updates to production only and runs once a week. This way we can reduce the deluge of PRrs and bring things in line until we can come up with a better solution.
test/.prettierrc
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "singleQuote": true, | |||
There was a problem hiding this comment.
it's interesting that this is single quote, but the src file has been updated to be all double quotes
There was a problem hiding this comment.
Good catch. I thin it's because I accidentally put it in the /tests folder.
|
i would also add |
alexs-mparticle
changed the title
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)