Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Consent State #43

Merged
merged 12 commits into from
Sep 30, 2024

Conversation

alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Sep 23, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Testing Plan

  • Was this tested locally? If not, explain why.
  • Load up the Kit in a sample app and fire events
  • In the network tab, all events that go to Bing should now have a new property ASC with a G for consent Granted and D for Consent Denied

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle force-pushed the feat/SQDSDKS-6745-add-consent-support branch from e51c5f9 to fa9ebf2 Compare September 23, 2024 21:58
@alexs-mparticle alexs-mparticle changed the base branch from master to development September 23, 2024 22:04
@alexs-mparticle alexs-mparticle force-pushed the feat/SQDSDKS-6745-add-consent-support branch from fb6fd0c to 4c4fc48 Compare September 23, 2024 22:05
@alexs-mparticle alexs-mparticle marked this pull request as ready for review September 24, 2024 15:24
Copy link
Collaborator

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't gone through the tests yet, but here's some initial feedback on the src code

src/BingAdsEventForwarder.js Outdated Show resolved Hide resolved
src/BingAdsEventForwarder.js Outdated Show resolved Hide resolved
src/BingAdsEventForwarder.js Show resolved Hide resolved
src/BingAdsEventForwarder.js Outdated Show resolved Hide resolved
src/BingAdsEventForwarder.js Outdated Show resolved Hide resolved
src/BingAdsEventForwarder.js Outdated Show resolved Hide resolved
src/BingAdsEventForwarder.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
test/src/tests.js Outdated Show resolved Hide resolved
@alexs-mparticle alexs-mparticle merged commit 122e318 into development Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants