-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Consent State #43
Merged
alexs-mparticle
merged 12 commits into
development
from
feat/SQDSDKS-6745-add-consent-support
Sep 30, 2024
Merged
feat: Add support for Consent State #43
alexs-mparticle
merged 12 commits into
development
from
feat/SQDSDKS-6745-add-consent-support
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
force-pushed
the
feat/SQDSDKS-6745-add-consent-support
branch
from
September 23, 2024 21:58
e51c5f9
to
fa9ebf2
Compare
alexs-mparticle
force-pushed
the
feat/SQDSDKS-6745-add-consent-support
branch
from
September 23, 2024 22:05
fb6fd0c
to
4c4fc48
Compare
rmi22186
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i haven't gone through the tests yet, but here's some initial feedback on the src code
rmi22186
requested changes
Sep 26, 2024
rmi22186
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
development
Summary
Testing Plan
ASC
with aG
for consent Granted andD
for Consent DeniedReference Issue (For mParticle employees only. Ignore if you are an outside contributor)