Stringify array attributes as space delimited

Fixes twilio#497
mpeltonen · Nov 6, 2019 · a068ac2 · a068ac2
1 parent 6f514fb
commit a068ac2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/twiml/TwiML.js b/lib/twiml/TwiML.js
@@ -8,7 +8,18 @@ var builder = require('xmlbuilder');  /* jshint ignore:line */
  */
 /* jshint ignore:end */
 function TwiML() {
-  this.response = builder.create('Response').dec('1.0', 'UTF-8');
+  this.response = builder.create('Response', {
+    stringify: {
+      attValue: stringifyAttValue
+    }
+  }).dec('1.0', 'UTF-8');
+}
+
+function stringifyAttValue(value) {
+  if (Array.isArray(value)) {
+    return value.join(' ');
+  }
+  return value;
 }
 
 /* jshint ignore:start */

diff --git a/spec/unit/twiml/VoiceResponse.spec.js b/spec/unit/twiml/VoiceResponse.spec.js
@@ -165,6 +165,13 @@ describe('create voice response TwiML', function() {
     expect(actual.toString()).toEqual('<?xml version="1.0" encoding="UTF-8"?><Response><Dial timeout="5"><Number>+11234567890</Number></Dial><Reject/><Redirect>www.twilio.com</Redirect><Pause length="5"/></Response>');
   });
 
+  it('should serialize array attributes as space delimited', function() {
+    var actual = new VoiceResponse();
+    actual.dial().number({ statusCallbackEvents: ["initiated", "ringing"] }, '+11234567890')
+
+    expect(actual.toString()).toEqual('<?xml version="1.0" encoding="UTF-8"?><Response><Dial><Number statusCallbackEvents="initiated ringing">+11234567890</Number></Dial></Response>');
+  });
+
   it('should allow adding arbitrary text to leaf nodes', function() {
     var actual = new VoiceResponse();
     actual.hangup().addText('extra text');