Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and modernise UI #178

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Refactor and modernise UI #178

merged 1 commit into from
Jan 26, 2024

Conversation

adamgundry
Copy link
Contributor

@adamgundry adamgundry commented Oct 19, 2023

This refactors some of the internal code and makes a variety of UI tweaks:

  • Tabs now use Bootstrap (added a dependency on popper.js)
  • The layout has been condensed
  • A new "Meta" tab shows metadata that is not relevant for every view
  • Heap profiling tabs are combined into a single dropdown
  • Tabs appear even if the underlying data is not available, with an explanation how to get the data (some of these explanations need work)
  • Tabs can have documentation associated with them; so far this exists partially for the "Heap" tab
  • When using -hi profiling, the main heap profile charts show the info table name (if available) in addition to the pointer
  • Ticky data is displayed in a separate tab (if available), alongside the other tabs, rather than being a separate mode

This is joint work with @adinapoli.

Screenshot

Screenshot when no data available

@BinderDavid
Copy link
Collaborator

BinderDavid commented Oct 19, 2023

We are sadly still blocked on #176 :( I can see whether I find the time on Sunday to rewrite the Github actions.
But the new layout looks very nice :)

@TeofilC
Copy link
Contributor

TeofilC commented Oct 19, 2023

Wow this looks great from the screenshots!

@BinderDavid
Copy link
Collaborator

BinderDavid commented Oct 19, 2023

Looking at the log, I think CI can maybe also be fixed by just updating the cachix action: cachix/cachix-action#144 (-> #179)

Edit: CI is fixed on main now.

@adamgundry
Copy link
Contributor Author

Thanks for the prompt action on the CI @BinderDavid! Looks like CI is now green, though I don't know if there is a way to see the generated Hakyll site that it built?

@TeofilC
Copy link
Contributor

TeofilC commented Jan 17, 2024

Super minor thing, but would it be possible to remove the delay/transition when switching tabs

@adinapoli
Copy link

Super minor thing, but would it be possible to remove the delay/transition when switching tabs

It should be configurable via bootstrap if memory serves me well, but I will double check later this week.

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, only some nitpicking changes

versions.json Outdated Show resolved Hide resolved
src/Eventlog/AssetVersions.hs Outdated Show resolved Hide resolved
src/Eventlog/Ticky.hs Outdated Show resolved Hide resolved
@fendor fendor mentioned this pull request Jan 26, 2024
@fendor
Copy link
Collaborator

fendor commented Jan 26, 2024

Manually validated that the gh-pages render properly for this patch

@fendor
Copy link
Collaborator

fendor commented Jan 26, 2024

It should be configurable via bootstrap if memory serves me well, but I will double check later this week.

Fixed as well.

This refactors some of the internal code and makes a variety of UI tweaks:

* Tabs now use Bootstrap (added a dependency on popper.js)
* The layout has been condensed
* A new "Meta" tab shows metadata that is not relevant for every view
* Heap profiling tabs are combined into a single dropdown
* Tabs appear even if the underlying data is not available, with an
    explanation how to get the data (some of these explanations need work)
* Tabs can have documentation associated with them; so far this exists
    partially for the "Heap" tab
* When using -hi profiling, the main heap profile charts show the info table
    name (if available) in addition to the pointer
* Ticky data is displayed in a separate tab (if available), alongside the
    other tabs, rather than being a separate mode

Unrelated, CI uploads site artefacts, so that we can review them
manually.
@fendor fendor merged commit 8060561 into mpickering:master Jan 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants