-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and modernise UI #178
Conversation
We are sadly still blocked on #176 :( I can see whether I find the time on Sunday to rewrite the Github actions. |
Wow this looks great from the screenshots! |
Looking at the log, I think CI can maybe also be fixed by just updating the cachix action: cachix/cachix-action#144 (-> #179) Edit: CI is fixed on |
Thanks for the prompt action on the CI @BinderDavid! Looks like CI is now green, though I don't know if there is a way to see the generated Hakyll site that it built? |
Super minor thing, but would it be possible to remove the delay/transition when switching tabs |
It should be configurable via bootstrap if memory serves me well, but I will double check later this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, only some nitpicking changes
Manually validated that the gh-pages render properly for this patch |
Fixed as well. |
This refactors some of the internal code and makes a variety of UI tweaks: * Tabs now use Bootstrap (added a dependency on popper.js) * The layout has been condensed * A new "Meta" tab shows metadata that is not relevant for every view * Heap profiling tabs are combined into a single dropdown * Tabs appear even if the underlying data is not available, with an explanation how to get the data (some of these explanations need work) * Tabs can have documentation associated with them; so far this exists partially for the "Heap" tab * When using -hi profiling, the main heap profile charts show the info table name (if available) in addition to the pointer * Ticky data is displayed in a separate tab (if available), alongside the other tabs, rather than being a separate mode Unrelated, CI uploads site artefacts, so that we can review them manually.
This refactors some of the internal code and makes a variety of UI tweaks:
popper.js
)-hi
profiling, the main heap profile charts show the info table name (if available) in addition to the pointerThis is joint work with @adinapoli.