Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC-9.8.1 #181

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Support GHC-9.8.1 #181

merged 1 commit into from
Feb 3, 2024

Conversation

TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Jan 15, 2024

Adds support for GHC 9.8.1.

This depends on this MR:

@BinderDavid
Copy link
Collaborator

Looks good! But I am a bit surprised that the CI for 9.8.1 already runs through: If I understood correctly the released version of ghc-events still has a base upper-bound of <0.19 🤔 , so it should only run through once a new ghc-events version is available.

@BinderDavid BinderDavid self-requested a review January 15, 2024 14:36
@TeofilC
Copy link
Contributor Author

TeofilC commented Jan 15, 2024

Looks good! But I am a bit surprised that the CI for 9.8.1 already runs through: If I understood correctly the released version of ghc-events still has a base upper-bound of <0.19 🤔 , so it should only run through once a new ghc-events version is available.

That's because I've also temporarily added an allow-newer pragma to the cabal.project until a new version/revision of ghc-events is released.

@BinderDavid
Copy link
Collaborator

Ah, I saw that line but I guess that I misunderstood the semantics of allow-newer. I thought that this only allows to pick a version of ghc-events that is greater than the upper bound that the cabal file allows.

Do you want to merge this now or should we wait for a new release of ghc-events?

@TeofilC
Copy link
Contributor Author

TeofilC commented Jan 15, 2024

Yeah I find that confusing too. I think if I had it without the :* then it would be what you mention (IIRC).

It's up to you, but my preference is to wait.

@TeofilC
Copy link
Contributor Author

TeofilC commented Feb 3, 2024

This is unblocked now. I've removed the allow-newer and it should be good to go

@BinderDavid BinderDavid merged commit 9ce6241 into mpickering:master Feb 3, 2024
9 checks passed
@BinderDavid
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants