Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning that the AS contains nodes orphaned and inaccessible for browsing starting from the Root node #529

Closed
mpostol opened this issue Feb 15, 2021 · 0 comments · Fixed by #571
Assignees
Labels
Bug Bug in the code.

Comments

@mpostol
Copy link
Owner

mpostol commented Feb 15, 2021

Describe the bug

Some nodes imported using UANodeSet document are not selected by the ValidateAndExportModel.

It is a blocker for #510

To Reproduce

Use the model Opc.Ua.NodeSet2.TriCycleType_V1.1.xml

Expected behavior

Add a warning that the AS contains nodes orphaned and inaccessible for browsing starting from the Root node

Additional context

ValidateAndExportModel uses conditions defined in Part 5 8 Standard Objects and their Variables - it processes a selected model from an internal Address Space. If the node is not on the browse path available for an abstract client it is neglected.

@mpostol mpostol added the Bug Bug in the code. label Feb 15, 2021
@mpostol mpostol self-assigned this Feb 15, 2021
@mpostol mpostol added this to the SemanticData_6.1.3 milestone Feb 15, 2021
mpostol added a commit that referenced this issue Feb 15, 2021
…r browsing starting from the Root node #529

- reviewed the code and added anchors for affected code.
mpostol added a commit that referenced this issue Feb 15, 2021
…r browsing starting from the Root node #529

- reviewing the errors tracing infrastructure - working copy
mpostol added a commit that referenced this issue Feb 16, 2021
…r browsing starting from the Root node #529

- fixed reviewing the errors tracing infrastructure - working copy
- UT 👍
mpostol added a commit that referenced this issue Feb 17, 2021
…r browsing starting from the Root node #529

- added testing fixture
- UT 👍
mpostol added a commit that referenced this issue Feb 17, 2021
…r browsing starting from the Root node #529

- added testing fixture
- UT 👍
mpostol added a commit that referenced this issue Feb 21, 2021
…r browsing starting from the Root node #529

- prototyping with XMLModelsProblemsToReportUnitTest.cs
- Added errors to signal that nodes have been duplicated (have same NodeId)
- working copy
mpostol added a commit that referenced this issue Feb 23, 2021
…r browsing starting from the Root node #529

-Prototyping with that - working on an algorithm to compare nodes in UANodesSet and ModelDesign.
- UT 👍
mpostol added a commit that referenced this issue Apr 9, 2021
…r browsing starting from the Root node #529

- added message for all not defined nodes in the origin UANodeSet file.
mpostol added a commit that referenced this issue Apr 10, 2021
@mpostol mpostol linked a pull request Apr 10, 2021 that will close this issue
mpostol added a commit that referenced this issue Apr 10, 2021
Semantic data 6.1.3 => master fixes #529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug in the code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant