Skip to content

Commit

Permalink
logs p34
Browse files Browse the repository at this point in the history
  • Loading branch information
akalitenya committed Nov 16, 2022
1 parent 626786f commit 917f2f5
Show file tree
Hide file tree
Showing 17 changed files with 95 additions and 184 deletions.
6 changes: 0 additions & 6 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ BACKEND_MAILGUN_DOMAIN=
BACKEND_LOG_IS_JSON=FALSE
BACKEND_LOG_RESPONSE_ERROR=FALSE
BACKEND_LOG_RESPONSE_OK=FALSE
BACKEND_LOG_ON_SENDER=FALSE
BACKEND_LOG_ON_RESPONSER=TRUE

BLOCKML_ENV=PROD
BLOCKML_RABBIT_PROTOCOL=amqp
Expand All @@ -149,8 +147,6 @@ BLOCKML_CONCURRENCY_LIMIT=0
BLOCKML_LOG_IS_JSON=FALSE
BLOCKML_LOG_RESPONSE_ERROR=FALSE
BLOCKML_LOG_RESPONSE_OK=FALSE
BLOCKML_LOG_ON_SENDER=FALSE
BLOCKML_LOG_ON_RESPONSER=TRUE

DISK_ENV=PROD
DISK_ORGANIZATIONS_PATH=/root/mprove_data/organizations
Expand All @@ -163,8 +159,6 @@ DISK_RABBIT_PORT=5672
DISK_LOG_IS_JSON=FALSE
DISK_LOG_RESPONSE_ERROR=FALSE
DISK_LOG_RESPONSE_OK=FALSE
DISK_LOG_ON_SENDER=FALSE
DISK_LOG_ON_RESPONSER=TRUE

CLI_TYPEORM_HOST=db
CLI_TYPEORM_USERNAME=root
Expand Down
190 changes: 92 additions & 98 deletions .helm/secret-values.yaml

Large diffs are not rendered by default.

8 changes: 0 additions & 8 deletions apps/backend/src/config/get-dev.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,6 @@ export function getDevConfig(envFilePath: any) {

backendLogResponseOk: <common.BoolEnum>(
(process.env.BACKEND_LOG_RESPONSE_OK || envFile.BACKEND_LOG_RESPONSE_OK)
),

backendLogOnSender: <common.BoolEnum>(
(process.env.BACKEND_LOG_ON_SENDER || envFile.BACKEND_LOG_ON_SENDER)
),

backendLogOnResponser: <common.BoolEnum>(
(process.env.BACKEND_LOG_ON_RESPONSER || envFile.BACKEND_LOG_ON_RESPONSER)
)
};

Expand Down
7 changes: 1 addition & 6 deletions apps/backend/src/functions/log-response-backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@ export function logResponseBackend(item: {
) === common.BoolEnum.TRUE &&
response.info.status === enums.ResponseInfoStatusEnum.Error;

if (
cs.get<interfaces.Config['backendLogOnResponser']>(
'backendLogOnResponser'
) === common.BoolEnum.TRUE &&
(isLogOk || isLogError)
) {
if (isLogOk || isLogError) {
let log = {
response: Object.assign({}, response, { payload: undefined })
};
Expand Down
5 changes: 0 additions & 5 deletions apps/backend/src/functions/make-error-response-backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ export function makeErrorResponseBackend(item: {
'backendLogResponseError'
)
),
logOnResponser: common.enumToBoolean(
cs.get<interfaces.Config['backendLogOnResponser']>(
'backendLogOnResponser'
)
),
logIsJson: common.enumToBoolean(
cs.get<interfaces.Config['backendLogIsJson']>('backendLogIsJson')
),
Expand Down
5 changes: 0 additions & 5 deletions apps/backend/src/functions/make-ok-response-backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ export function makeOkResponseBackend(item: {
logResponseOk: common.enumToBoolean(
cs.get<interfaces.Config['backendLogResponseOk']>('backendLogResponseOk')
),
logOnResponser: common.enumToBoolean(
cs.get<interfaces.Config['backendLogOnResponser']>(
'backendLogOnResponser'
)
),
logIsJson: common.enumToBoolean(
cs.get<interfaces.Config['backendLogIsJson']>('backendLogIsJson')
),
Expand Down
6 changes: 0 additions & 6 deletions apps/backend/src/interfaces/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,4 @@ export class Config {

@IsEnum(common.BoolEnum)
backendLogResponseOk?: common.BoolEnum;

@IsEnum(common.BoolEnum)
backendLogOnSender?: common.BoolEnum;

@IsEnum(common.BoolEnum)
backendLogOnResponser?: common.BoolEnum;
}
6 changes: 0 additions & 6 deletions apps/blockml/src/config/get-dev.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,6 @@ export function getDevConfig(envFilePath: any) {
),
blockmlLogResponseOk: <common.BoolEnum>(
(process.env.BLOCKML_LOG_RESPONSE_OK || envFile.BLOCKML_LOG_RESPONSE_OK)
),
blockmlLogOnSender: <common.BoolEnum>(
(process.env.BLOCKML_LOG_ON_SENDER || envFile.BLOCKML_LOG_ON_SENDER)
),
blockmlLogOnResponser: <common.BoolEnum>(
(process.env.BLOCKML_LOG_ON_RESPONSER || envFile.BLOCKML_LOG_ON_RESPONSER)
)
};
return devConfig;
Expand Down
5 changes: 0 additions & 5 deletions apps/blockml/src/functions/make-error-response-blockml.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ export function makeErrorResponseBlockml(item: {
'blockmlLogResponseError'
)
),
logOnResponser: common.enumToBoolean(
cs.get<interfaces.Config['blockmlLogOnResponser']>(
'blockmlLogOnResponser'
)
),
logIsJson: common.enumToBoolean(
cs.get<interfaces.Config['blockmlLogIsJson']>('blockmlLogIsJson')
),
Expand Down
5 changes: 0 additions & 5 deletions apps/blockml/src/functions/make-ok-response-blockml.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ export function makeOkResponseBlockml(item: {
logResponseOk: common.enumToBoolean(
cs.get<interfaces.Config['blockmlLogResponseOk']>('blockmlLogResponseOk')
),
logOnResponser: common.enumToBoolean(
cs.get<interfaces.Config['blockmlLogOnResponser']>(
'blockmlLogOnResponser'
)
),
logIsJson: common.enumToBoolean(
cs.get<interfaces.Config['blockmlLogIsJson']>('blockmlLogIsJson')
),
Expand Down
6 changes: 0 additions & 6 deletions apps/blockml/src/interfaces/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,4 @@ export class Config {

@IsEnum(common.BoolEnum)
blockmlLogResponseOk?: common.BoolEnum;

@IsEnum(common.BoolEnum)
blockmlLogOnSender?: common.BoolEnum;

@IsEnum(common.BoolEnum)
blockmlLogOnResponser?: common.BoolEnum;
}
6 changes: 0 additions & 6 deletions apps/disk/src/config/get-dev.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ export function getDevConfig(envFilePath: any) {
),
diskLogResponseOk: <common.BoolEnum>(
(process.env.DISK_LOG_RESPONSE_OK || envFile.DISK_LOG_RESPONSE_OK)
),
diskLogOnSender: <common.BoolEnum>(
(process.env.DISK_LOG_ON_SENDER || envFile.DISK_LOG_ON_SENDER)
),
diskLogOnResponser: <common.BoolEnum>(
(process.env.DISK_LOG_ON_RESPONSER || envFile.DISK_LOG_ON_RESPONSER)
)
};
return devConfig;
Expand Down
3 changes: 0 additions & 3 deletions apps/disk/src/functions/make-error-response-disk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ export function makeErrorResponseDisk(item: {
logResponseError: common.enumToBoolean(
cs.get<interfaces.Config['diskLogResponseError']>('diskLogResponseError')
),
logOnResponser: common.enumToBoolean(
cs.get<interfaces.Config['diskLogOnResponser']>('diskLogOnResponser')
),
logIsJson: common.enumToBoolean(
cs.get<interfaces.Config['diskLogIsJson']>('diskLogIsJson')
),
Expand Down
3 changes: 0 additions & 3 deletions apps/disk/src/functions/make-ok-response-disk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ export function makeOkResponseDisk(item: {
logResponseOk: common.enumToBoolean(
cs.get<interfaces.Config['diskLogResponseOk']>('diskLogResponseOk')
),
logOnResponser: common.enumToBoolean(
cs.get<interfaces.Config['diskLogOnResponser']>('diskLogOnResponser')
),
logIsJson: common.enumToBoolean(
cs.get<interfaces.Config['diskLogIsJson']>('diskLogIsJson')
),
Expand Down
6 changes: 0 additions & 6 deletions apps/disk/src/interfaces/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,4 @@ export class Config {

@IsEnum(common.BoolEnum)
diskLogResponseOk?: common.BoolEnum;

@IsEnum(common.BoolEnum)
diskLogOnSender?: common.BoolEnum;

@IsEnum(common.BoolEnum)
diskLogOnResponser?: common.BoolEnum;
}
8 changes: 1 addition & 7 deletions libs/node-common/src/functions/make-error-response.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export function makeErrorResponse(item: {
duration: number;
skipLog?: boolean;
logResponseError: boolean;
logOnResponser: boolean;
logIsJson: boolean;
logger: Logger;
}) {
Expand All @@ -24,7 +23,6 @@ export function makeErrorResponse(item: {
duration,
skipLog,
logResponseError,
logOnResponser,
logIsJson,
logger
} = item;
Expand All @@ -41,11 +39,7 @@ export function makeErrorResponse(item: {
payload: {}
};

if (
logOnResponser === true &&
logResponseError === true &&
skipLog !== true
) {
if (logResponseError === true && skipLog !== true) {
let log = {
response: Object.assign({}, response, { payload: undefined })
};
Expand Down
4 changes: 1 addition & 3 deletions libs/node-common/src/functions/make-ok-response.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export function makeOkResponse(item: {
duration: number;
skipLog?: boolean;
logResponseOk: boolean;
logOnResponser: boolean;
logIsJson: boolean;
logger: Logger;
}) {
Expand All @@ -23,7 +22,6 @@ export function makeOkResponse(item: {
duration,
skipLog,
logResponseOk,
logOnResponser,
logIsJson,
logger
} = item;
Expand All @@ -39,7 +37,7 @@ export function makeOkResponse(item: {
payload: payload
};

if (logOnResponser === true && logResponseOk === true && skipLog !== true) {
if (logResponseOk === true && skipLog !== true) {
let log = {
response: Object.assign({}, response, { payload: undefined })
};
Expand Down

0 comments on commit 917f2f5

Please sign in to comment.