Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture the raised exception for error reporting #862

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

cclauss
Copy link

@cclauss cclauss commented Jul 6, 2018

Capture the raised exception in the variable e on line 39 so that it can be recorded on line 41.

flake8 testing of https://github.com/mps-youtube/mps-youtube on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./mps_youtube/commands/lastfm.py:41:63: F821 undefined name 'e'
            g.message = "Last.fm connection error: %s" % (str(e))
                                                              ^
1     F821 undefined name 'e'
1

Capture the raised exception in the variable __e__ on line 39 so that it can be recorded on line 41.

flake8 testing of https://github.com/mps-youtube/mps-youtube on Python 3.6.3

$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__
```
./mps_youtube/commands/lastfm.py:41:63: F821 undefined name 'e'
            g.message = "Last.fm connection error: %s" % (str(e))
                                                              ^
1     F821 undefined name 'e'
1
```
@tommysolsen tommysolsen self-requested a review July 6, 2018 16:49
Copy link
Member

@tommysolsen tommysolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tommysolsen tommysolsen merged commit f108f06 into mps-youtube:develop Jul 6, 2018
@cclauss cclauss deleted the patch-1 branch July 6, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants