wayland: add cursor-shape-v1 support #11701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudemanguy
force-pushed
the
wayland-cursor
branch
3 times, most recently
from
c037041
to
46a8009
Compare
Nefsen402
reviewed
May 26, 2023
Dudemanguy
force-pushed
the
wayland-cursor
branch
from
46a8009
to
bc06765
Compare
Nefsen402
reviewed
May 26, 2023
Dudemanguy
force-pushed
the
wayland-cursor
branch
from
bc06765
to
20cb71f
Compare
|
LGTM |
Dudemanguy
force-pushed
the
wayland-cursor
branch
from
20cb71f
to
fdc1b94
Compare
Dudemanguy
force-pushed
the
wayland-cursor
branch
from
fdc1b94
to
75d0db7
Compare
This protocol no longer requires us to draw a separate cursor surface and all of that horrible stuff. We can just ask the compositor for the default cursor instead since that's literally all mpv cares about.
Dudemanguy
force-pushed
the
wayland-cursor
branch
from
75d0db7
to
328819f
Compare
|
Works fine and since wayland protocols 1.32 is out now, there's no reason to hold this back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protocol no longer requires us to draw a separate cursor surface and all of that horrible stuff. We can just ask the compositor for the default cursor instead since that's literally all mpv cares about.
Should theoretically fix #11671.
Tested with https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4106 + swaywm/sway#7571. Also requires wayland-protocols from master right now hence draft.