Lua 5.3 changes #1516
Closed
Lua 5.3 changes #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Lua now has integers and is fairly strict about it, handle inf, nan, etc. by using default values if these pop up. This is observed when the OSC is initialized and the video size parameters are all 0 which turn into divide-by-zero (inf in Lua) which flows through and eventually are expected to be integers.
The string format is rejecting values like '400.9' because they can't be
(losslessly) converted to integers. See:
http://article.gmane.org/gmane.comp.lang.lua.general/113743
mathstuf
force-pushed
the
lua-5.3-changes
branch
from
d232953
to
92f25cd
Compare
mathstuf
force-pushed
the
lua-5.3-changes
branch
from
92f25cd
to
229678b
Compare
ghost
|
@wm4 Is Lua 5.3 something you're still interested in seeing? Or is it still too hard to support in parallel to the currently supported Lua versions? FWIW, Fedora no longer ships Lua modules for 5.1 which some scripts use (posix, socket-http for |
|
Supporting 5.3 would be ok, but I still think it'd be chaos to support both 5.3 and 5.2 at once. Does luajit support 5.3 yet? |
|
The luajit developer(s?) seem to not like 5.3, so "unlikely". This Reddit thread has some discussion. Apparently even 5.2 isn't fully supported either ( |
|
This can be closed for the same reason as #1914. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It at least doesn't disappear with light usage now. Probably more lurking, but this should be enough to at least play around with 5.3 (5.2 is untested since I don't have it right now).